Various improvements

staudenmeir · Feb 24, 2019 · 6cf2ba4 · 6cf2ba4
1 parent e558f01
commit 6cf2ba4
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 8 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -1,5 +1,8 @@
-/tests            export-ignore
-/.gitattributes   export-ignore
-/.gitignore       export-ignore
-/.travis.yml      export-ignore
-/phpunit.xml.dist export-ignore
+/tests             export-ignore
+.gitattributes     export-ignore
+.gitignore         export-ignore
+.scrutinizer.yml   export-ignore
+.travis.yml        export-ignore
+CODE_OF_CONDUCT.md export-ignore
+CONTRIBUTING.md    export-ignore
+phpunit.xml.dist   export-ignore
diff --git a/CONDUCT.md → CODE_OF_CONDUCT.md b/CONDUCT.md → CODE_OF_CONDUCT.md
diff --git a/README.md b/README.md
@@ -82,7 +82,7 @@ class Comment extends Model
 
 ## Contributing
 
-Please see [CONTRIBUTING](CONTRIBUTING.md) and [CONDUCT](CONDUCT.md) for details.
+Please see [CONTRIBUTING](CONTRIBUTING.md) and [CODE OF CONDUCT](CODE_OF_CONDUCT.md) for details.
 
 ## Credits
 

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -11,7 +11,7 @@
          verbose="true"
 >
     <testsuites>
-        <testsuite>
+        <testsuite name="BelongsToThrough Test Suite">
             <directory suffix="Test.php">./tests</directory>
         </testsuite>
     </testsuites>

diff --git a/src/Relations/BelongsToThrough.php b/src/Relations/BelongsToThrough.php
@@ -191,7 +191,7 @@ protected function setRelationQueryConstraints(Builder $query)
             if ($lastIndex === $index) {
                 $prev = $this->prefix.$prev; // TODO: Check if this line is really necessary. Its not covered by any of the tests.
             }
-            if ($this->getParent()->getTable() == $model->getTable()) {
+            if ($this->getParent()->getTable() === $model->getTable()) {
                 $alias = $model->getTable().'_'.time();
                 $other = $alias.'.'.$prev;
                 $query->leftJoin(new Expression($model->getTable().' as '.$alias), $one, '=', $other);