Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21483] fix: update collectible amounts after sending #21867

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Dec 25, 2024

fixes #21483

Summary

Multicollectible amount is not updated after transaction until relogin

Areas that maybe impacted

  • Send collectible

Steps to test

  1. Send multicollectible from Account A to internal Account B
  2. See if collectible amount has been updated after pull to refresh

Note for Test

As you can see in the video, receiving the updated balance may take some time (in my case, approximately 50 seconds). Once a signal confirming the ownership transfer is received, the balance will be updated accordingly

Result

Simulator.Screen.Recording.-.iPhone.13.-.2025-01-07.at.21.38.45.mp4

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Dec 25, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Dec 25, 2024

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ddde37e #1 2024-12-25 10:46:29 ~5 min tests 📄log
✔️ ddde37e #1 2024-12-25 10:47:51 ~6 min ios 📱ipa 📲
✔️ ddde37e #1 2024-12-25 10:50:16 ~9 min android-e2e 🤖apk 📲
✔️ ddde37e #1 2024-12-25 10:50:45 ~9 min android 🤖apk 📲
✔️ c1cb39d #2 2025-01-07 15:32:33 ~4 min tests 📄log
✔️ c1cb39d #2 2025-01-07 15:34:43 ~7 min ios 📱ipa 📲
✔️ c1cb39d #2 2025-01-07 15:36:26 ~8 min android-e2e 🤖apk 📲
✔️ c1cb39d #2 2025-01-07 15:36:53 ~9 min android 🤖apk 📲
✔️ 8bcdc45 #4 2025-01-07 18:49:14 ~5 min tests 📄log
✔️ 8bcdc45 #4 2025-01-07 18:51:49 ~7 min ios 📱ipa 📲
✔️ 8bcdc45 #4 2025-01-07 18:52:42 ~8 min android-e2e 🤖apk 📲
✔️ 8bcdc45 #4 2025-01-07 18:53:16 ~9 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
b321c72 #5 2025-01-08 09:02:21 ~3 min tests 📄log
✔️ b321c72 #5 2025-01-08 09:05:48 ~6 min ios 📱ipa 📲
✔️ b321c72 #5 2025-01-08 09:07:45 ~8 min android-e2e 🤖apk 📲
✔️ b321c72 #5 2025-01-08 09:08:13 ~9 min android 🤖apk 📲
✔️ 1bac99f #6 2025-01-08 09:31:13 ~4 min tests 📄log
✔️ 1bac99f #6 2025-01-08 09:34:18 ~7 min ios 📱ipa 📲
✔️ 1bac99f #6 2025-01-08 09:35:15 ~8 min android-e2e 🤖apk 📲
✔️ 1bac99f #6 2025-01-08 09:35:46 ~9 min android 🤖apk 📲

@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/collectible-amount-update branch from ddde37e to c1cb39d Compare January 7, 2025 15:27
@shivekkhurana shivekkhurana added the wallet-core Issues for mobile wallet team label Jan 7, 2025
@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/collectible-amount-update branch 2 times, most recently from 7f9dd57 to 8bcdc45 Compare January 7, 2025 18:43
@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/collectible-amount-update branch from 8bcdc45 to b321c72 Compare January 8, 2025 08:58
@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/collectible-amount-update branch from b321c72 to 1bac99f Compare January 8, 2025 09:26
@mohsen-ghafouri mohsen-ghafouri marked this pull request as ready for review January 8, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wallet-core Issues for mobile wallet team
Projects
Status: REVIEW
Development

Successfully merging this pull request may close these issues.

Multicollectible amount is not updated after transaction until relogin
3 participants