Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use image clock when updating profile images to cause re-render #21830

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

seanstrom
Copy link
Member

@seanstrom seanstrom commented Dec 16, 2024

Attention

cc @alwx


fixes #21787

Summary

  • This PR attempts to fix an issue with account images not re-rendering after updating the profile image.
    • Currently this PR fixes the issue by associating a clock value to the identity images that are returned by status-go, because for some reason the clocks are defaulted to 0.
    • Likely we'll need to update status-go to populate the image clocks before forwarding the results.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • Profile images

Steps to test

WIP

Before and after screenshots comparison

After Changes on iOS

Screen.Recording.2024-12-12.at.09.29.39.mov

status: ready

@seanstrom seanstrom requested a review from alwx December 16, 2024 15:50
@seanstrom seanstrom self-assigned this Dec 16, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Dec 16, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9d1d6c6 #1 2024-12-16 15:55:48 ~5 min tests 📄log
✔️ 9d1d6c6 #1 2024-12-16 15:58:33 ~8 min ios 📱ipa 📲
✔️ 9d1d6c6 #1 2024-12-16 16:00:12 ~9 min android-e2e 🤖apk 📲
✔️ 9d1d6c6 #1 2024-12-16 16:00:26 ~9 min android 🤖apk 📲
✔️ 0a5a783 #2 2025-01-10 11:16:11 ~4 min tests 📄log
0a5a783 #2 2025-01-10 11:18:49 ~7 min ios 📄log
✔️ 0a5a783 #2 2025-01-10 11:20:32 ~9 min android-e2e 🤖apk 📲
✔️ 0a5a783 #2 2025-01-10 11:21:14 ~10 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fc9d21d #3 2025-01-10 11:33:28 ~5 min tests 📄log
✔️ fc9d21d #3 2025-01-10 11:35:10 ~7 min android-e2e 🤖apk 📲
✔️ fc9d21d #3 2025-01-10 11:35:36 ~7 min ios 📱ipa 📲
✔️ fc9d21d #3 2025-01-10 11:36:32 ~8 min android 🤖apk 📲
✔️ d3228b1 #4 2025-01-10 13:53:53 ~4 min tests 📄log
✔️ d3228b1 #4 2025-01-10 13:56:20 ~7 min android-e2e 🤖apk 📲
✔️ d3228b1 #4 2025-01-10 13:56:40 ~7 min android 🤖apk 📲
✔️ d3228b1 #4 2025-01-10 14:01:47 ~12 min ios 📱ipa 📲

@alwx alwx merged commit 394648b into develop Jan 10, 2025
5 checks passed
@alwx alwx deleted the seanstrom/fix-account-image-rerender branch January 10, 2025 14:01
@alwx
Copy link
Contributor

alwx commented Jan 10, 2025

Merged this one because the PR is a duplicate of a PR that was already tested and merged to the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

Profile photo is not updated until re-login when it is not empty
3 participants