Add Stream support to JdbcAggregateOperations #1963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: enhancement
schauder
requested changes
Jan 14, 2025
| @@ -15,14 +15,9 @@ | |||
| */ | |||
| package org.springframework.data.jdbc.mybatis; | |||
|
|
|||
| import static java.util.Arrays.*; | |||
There was a problem hiding this comment.
Please avoid reformatting the code.
See https://github.com/spring-projects/spring-data-build/tree/main/etc/ide for how to setup the formatter of your IDE.
| @@ -149,7 +149,7 @@ protected RelationalPersistentProperty createPersistentProperty(Property propert | |||
|
|
|||
| /** | |||
| * @since 3.2 | |||
| * @return iff single query loading is enabled. | |||
There was a problem hiding this comment.
The double f is actually intentionally.
There was a problem hiding this comment.
Ops, sorry :) I'll fix it
serezakorotaev
force-pushed
the
GH-1714
branch
from
569f382 to
6da1df3
Compare
|
Hi! |
Signed-off-by: Sergey Korotaev <[email protected]>
serezakorotaev
force-pushed
the
GH-1714
branch
from
6da1df3 to
14dd7c8
Compare
This was
unlinked from
issues
Jan 16, 2025
schauder
pushed a commit
that referenced
this pull request
Jan 16, 2025
See #1714 Original pull request #1963 Signed-off-by: Sergey Korotaev <[email protected]>
|
Thanks, that's merged. |
|
Super, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, everyone!
I wanted to contribute for you and started with this PR :)
I have added Stream support to JdbcAggregateOperations. These methods use other methods at the db level with the return value type stream (or cursor for MyBatis).
I also read that findAll** is a reserved naming convention, for the sake of similarity I added findAllStreamable or something like that.
Added tests for these methods.
Closes #1714