Feature/strimzi helm #282
Open
Feature/strimzi helm #282
+983
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n bytesin/bytesout every 10 minutes
it's not yet clear how to best cut this into subcharts
…mages, use a fixed one
stmichael
reviewed
Jan 8, 2025
| debug = true | ||
| quiet = false | ||
|
|
||
| [[inputs.prometheus]] |
There was a problem hiding this comment.
Just as a note: This telegraf config is specific to strimzi. For the moment this is fine. With helm we could however let the user choose whether metrics should be taken from strimzi, Confluent or both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers:
I initially based this branch on @stmichael 's branch with the strimzi-telegraf setup. Hence there are some changes from those commits that are showing up in the diff. Not quite sure why (I thought those changes have been merged already?)
The truly new code is all in the
helmfolder. I have added some TODOs throughout the code. These are things that we must have in the future (to support all possible Strimzi setups), but are not essential for a basic setup (non-TLS Kafka listener, just one Strimzi cluster). The team can decide whether we want to work on them as part of this (already very large) PR or rather create follow-up issues for them, to be solved separately.