Lazy loading with pipelineRef #4820
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…naker#4814) (cherry picked from commit 266ce73) Co-authored-by: Christos Arvanitis <[email protected]>
…to PipelineRefTrigger (spinnaker#4816) (spinnaker#4818) * fix(pipelineRef): add resolvedExpectedArtifacts from pipelineTrigger to PipelineRefTrigger * fix(pipelineRef): add tests around PipelineRefTrigger --------- Co-authored-by: Jason <[email protected]> (cherry picked from commit 3c65fe0) Co-authored-by: Edgar Garcia <[email protected]>
|
Please delete the pull request instructions from the body of your pull request message. The instructions start with the line:
You can reopen your pull request when this has been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipeline triggers contains the whole execution of the parent execution. When a Spinnaker user defines multiple pipelines that are chained by pipeline triggers Spinnaker's UI is slowed down because it loads all nested executions.
Orca will return any execution to outsider services with PipelineRef trigger but for Orca itself it will use the whole execution context to evaluate SPeLs.
it will provide a new endpoint to retrieve the execution context including nested execution.