Skip to content

Added keyword and extended header output. #13

Added keyword and extended header output.

Added keyword and extended header output. #13

Triggered via push October 31, 2024 11:29
Status Failure
Total duration 31s
Artifacts

check.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

1 error and 12 warnings
test
Process completed with exit code 101.
/home/runner/work/bluefile/bluefile/src/lib.rs#L3
unused import: `std::io::BufReader`
/home/runner/work/bluefile/bluefile/src/lib.rs#L161
`to_string` applied to a type that implements `Display` in `write!` args
/home/runner/work/bluefile/bluefile/src/bluejay.rs#L99
length comparison to zero
/home/runner/work/bluefile/bluefile/src/bluejay.rs#L129
length comparison to zero
/home/runner/work/bluefile/bluefile/src/bluejay.rs#L137
the loop variable `i` is used to index `keywords`
unused import: `std::io::BufReader`: src/lib.rs#L3
warning: unused import: `std::io::BufReader` --> src/lib.rs:3:5 | 3 | use std::io::BufReader; | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
`to_string` applied to a type that implements `Display` in `write!` args: src/lib.rs#L161
warning: `to_string` applied to a type that implements `Display` in `write!` args --> src/lib.rs:161:75 | 161 | 'A' => write!(f, "\"{}\"", from_utf8(&self.raw_value).unwrap().to_string()), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `#[warn(clippy::to_string_in_format_args)]` on by default
2 warnings emitted
warning: 2 warnings emitted
length comparison to zero: src/bluejay.rs#L99
warning: length comparison to zero --> src/bluejay.rs:99:8 | 99 | if header.keywords.len() == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `header.keywords.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default
length comparison to zero: src/bluejay.rs#L129
warning: length comparison to zero --> src/bluejay.rs:129:8 | 129 | if keywords.len() == 0 { | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keywords.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
the loop variable `i` is used to index `keywords`: src/bluejay.rs#L137
warning: the loop variable `i` is used to index `keywords` --> src/bluejay.rs:137:14 | 137 | for i in 0..keywords.len() { | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator and enumerate() | 137 | for (i, <item>) in keywords.iter().enumerate() { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
3 warnings emitted
warning: 3 warnings emitted