feat: promote speakeasy version on successful run #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -349,6 +353,20 @@ func runWithVersion(cmd *cobra.Command, artifactArch, desiredVersion string) err | |||
| return fmt.Errorf("failed to run with version %s: %w", desiredVersion, err) | |||
| } | |||
|
|
|||
| // If the workflow succeeded, make the used version the default | |||
| if promote && !env.IsGithubAction() && !env.IsLocalDev() { | |||
| currentExecPath, err := os.Executable() | |||
There was a problem hiding this comment.
I suppose there is a valid reason for us to prompt and only do this when we are in interactive mode and we know we can. Idk what do you think
There was a problem hiding this comment.
I tried that, and I'm open to it, but it just felt a bit tedious. Like, if the CLI just ran using that version, why would I not want to install it (that's what im imagining customers saying/thinking)
There was a problem hiding this comment.
ya that's fair.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
runcompletes successfully usinglatest, promote the used version to be the installed CLI version (as if the user had runspeakeasy update)Also cleans up some of the logging to be a bit less obnoxious
https://linear.app/speakeasy/issue/SPE-4408/speakeasy-run-too-many-version-update-mentions