Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: write_node doesn't need mut reference #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: write_node doesn't need mut reference #2

wants to merge 4 commits into from

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Apr 8, 2024 •
edited
Loading

Initially I thought mem_size may under-estimate. But later I found if it happens, encode_into_slice will fail first. So only leaving two trivial changes.

@zhiqiangxu zhiqiangxu changed the title flush if over sized chore: write_node doesn't need mut reference Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhiqiangxu