Blob UI: Disable return to target logic in blame popover UI

[vovakulikov]

Fixes https://github.com/sourcegraph/sourcegraph/issues/43335

Background

Previously before we merged https://github.com/sourcegraph/sourcegraph/pull/43029 the PopoverContent didn't do anything with focus (didn't return it to the original target) if focusLocked is specified and set to false. In https://github.com/sourcegraph/sourcegraph/pull/43029 I changed this behaviour, and now PopoverContent exposes the returnTargetFocus prop to turn on/off focus preservation after Popover has been closed.

The recursion (why we have problem in Blame annotations) is

• Blame line (let's call it target 1) is listening to focus and showing a tooltip on the focused target (let's call this Popover1)
• If you move the cursor (hover over another blame line, let's say target 2) or you're going through blame lines with a keyboard you focus next target (target 2), and the previous target (target 1) emits a blur which closes the Popover 1
• Since returnTargetFocus by default is true the Popover 1 returns popover to the target 1
• And this is a loop, you're hovering over target 2, and we close popover 1, which closes returns focus to target 1, and we open Popover 1

I shared my feedback about this that this blame popover should use a tooltip pattern and doesn't have any interactive element as content. And in this case, we wouldn't be needed in any focus popover-like management in this UI.

Test plan

• Open blob UI
• Try to open and hover/focus blame line annotation
• Commit message/info popover should work properly and without any freezes when you're navigating through blame line annotations

App preview:

• Web

Check out the client app preview documentation to learn more.

[sg-e2e-regression-test-bob]

Bundle size report 📦

Initial size	Total size	Async size	Modules
0.00% (0.00 kb)	0.00% (+0.04 kb)	0.00% (+0.04 kb)	0.00% (0)

Look at the Statoscope report for a full comparison between the commits 3c29d00 and a00f9e9 or learn more.

Open explanation

• Initial size is the size of the initial bundle (the one that is loaded when you open the page)
• Total size is the size of the initial bundle + all the async loaded chunks
• Async size is the size of all the async loaded chunks
• Modules is the number of modules in the initial bundle

[philipp-spiess]

Yep yep