Migrate to react router 7, typescript, and misc. refactoring #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrzrdx
commented
Nov 28, 2024
chrzrdx
commented
Nov 28, 2024
chrzrdx
commented
Nov 28, 2024
chrzrdx
commented
Nov 28, 2024
chrzrdx
commented
Nov 29, 2024
|
@sorokya did you get a chance to look at this yet? |
sorokya
requested changes
Dec 24, 2024
| import { glob } from 'glob'; | ||
| import { parseMarkdown } from './utils/parse-markdown'; | ||
|
|
||
| type Content = Awaited<ReturnType<typeof parseMarkdown>>; |
There was a problem hiding this comment.
Is Awaited a built in typescript type to describe an "awaited" value? Neat. Not sure why it's needed though really
There was a problem hiding this comment.
If we lose the Awaited, the type becomes wrapped in Promise<>, feels less "clean".
| } | ||
|
|
||
| const fileContents = fs.readFileSync(DATA_FILE_PATH, { encoding: 'utf8' }); | ||
| const json = JSON.parse(fileContents); |
There was a problem hiding this comment.
Shouldn't fileContents be json and this variable be named something else?
There was a problem hiding this comment.
I'd leave it as it is. fs.readFileSync outputs a string, which we parse as JSON in the second step.
|
@sorokya Anything else you'd like to see here before we get this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
Minor:
Pre-release steps (in dev and in prod):
bun upgrade)Known issues:
rm -rf .react-router && bun run devto generate types again.