Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better implicit param check #373

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Better implicit param check #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion macros/src/main/scala-3/com/softwaremill/macwire/internals/ConstructorCrimper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ private[macwire] class ConstructorCrimper[Q <: Quotes, T: Type](using val q: Q)(
private def isAccessibleConstructor(s: Symbol) =
s.isClassConstructor && !(s.flags is Flags.Private) && !(s.flags is Flags.Protected)

private def isImplicit(f: Flags): Boolean = f.is(Flags.Implicit) || f.is(Flags.Given)

lazy val publicConstructors: Iterable[Symbol] = {
val ctors = targetType.typeSymbol.declarations
.filter(isAccessibleConstructor)
Expand Down Expand Up @@ -96,7 +98,7 @@ private[macwire] class ConstructorCrimper[Q <: Quotes, T: Type](using val q: Q)(

def wireConstructorParamsWithImplicitLookups(paramLists: List[List[(Symbol, TypeRepr)]]): List[List[Term]] =
paramLists.map {
case params if params.forall(_._1.flags is Flags.Implicit) => params.map(resolveImplicitOrFail)
case params if params.forall(p => isImplicit(p._1.flags)) => params.map(resolveImplicitOrFail)
case params => params.map(p => dependencyResolver.resolve(p._1, /*SI-4751*/ p._2))
}

Expand Down