SNOW-1819523: Add support for expand=True in Series.str.split #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-helmeleegy
requested review from
sfc-gh-rdurrani and
sfc-gh-mvashishtha
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
sfc-gh-mvashishtha
approved these changes
Jan 14, 2025
sfc-gh-lmukhopadhyay
approved these changes
Jan 14, 2025
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
| @@ -16842,6 +16839,12 @@ def output_col( | |||
| if np.isnan(n): | |||
| # Follow pandas behavior | |||
| return pandas_lit(np.nan) | |||
| elif n < -1 and not pandas.isnull(pat) and len(str(pat)) > 1: | |||
| # Follow pandas behavior, which seems to leave the input column as is | |||
There was a problem hiding this comment.
nit: why seems to, I thought we should be sure it is or not; are we saying this is not 100% sure? 😆
There was a problem hiding this comment.
That's because this behavior is not documented by pandas. So it's just based on our experiments and observations (which are not / cannot be exhaustive). I updated the wording of the comment a little bit though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1819523
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add support for expand=True in Series.str.split.