Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1868288 log level to debug in chunk rowcount logging #2127

Merged

Conversation

sfc-gh-dszmolka
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-1868288

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Apparently for some workflows (SNOW-1868288: Downgrade cursor.py log level from info to debug #2126), the INFO level of current logging is excessive. Aiming to set it to DEBUG - if needed for troubleshooting, one usually uses verbose loglevels anyways.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-dszmolka sfc-gh-dszmolka added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Dec 24, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team December 24, 2024 18:17
@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team December 24, 2024 21:58
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-mkeller sfc-gh-mkeller merged commit 138241c into main Jan 2, 2025
94 checks passed
@sfc-gh-mkeller sfc-gh-mkeller deleted the SNOW-1868288-info-to-debug-in-first-chunk-logging branch January 2, 2025 22:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
@sfc-gh-mkeller sfc-gh-mkeller linked an issue Jan 2, 2025 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-1868288: Downgrade cursor.py log level from info to debug
2 participants