Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-979109: Support directories with GET and PUT of stages - NODE.JS #737

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Dec 20, 2023

Description

Please explain the changes you made here.

  • Added ** which includes the subdirectory for Put command.
  • Added a testing code for the new feature.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7207966) 89.95% compared to head (56fdff0) 88.66%.

❗ Current head 56fdff0 differs from pull request most recent head 0d78d81. Consider uploading reports for the commit 0d78d81 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage   89.95%   88.66%   -1.30%     
==========================================
  Files          59       61       +2     
  Lines        5615     5706      +91     
==========================================
+ Hits         5051     5059       +8     
- Misses        564      647      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant