Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release channel publish command #1972

Merged

Conversation

sfc-gh-melnacouzi
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Add release channel publish command:
snow app publish --version v1 --patch 0 [--directive d] [--channel c]

This command will:

  • add the version to the release channel if not already there
  • check if there is space in the release channel - if not remove old unused versions from there.
  • set the specified the release directive to the version and patch specified in the input.

@sfc-gh-melnacouzi sfc-gh-melnacouzi requested review from a team as code owners January 7, 2025 19:54
@sfc-gh-melnacouzi sfc-gh-melnacouzi enabled auto-merge (squash) January 7, 2025 20:21
@sfc-gh-melnacouzi sfc-gh-melnacouzi force-pushed the melnacouzi-add-release-channel-publish-command branch from 2bf2e63 to aedeb6f Compare January 7, 2025 20:49
sfc-gh-gbloom
sfc-gh-gbloom previously approved these changes Jan 7, 2025
@sfc-gh-melnacouzi sfc-gh-melnacouzi force-pushed the melnacouzi-add-release-channel-publish-command branch from a171655 to 0bfc89e Compare January 8, 2025 18:01
Copy link

@sfc-gh-xke sfc-gh-xke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve it since @sfc-gh-gbloom has approved before the rebase.

@sfc-gh-melnacouzi sfc-gh-melnacouzi merged commit 9433512 into main Jan 8, 2025
20 checks passed
@sfc-gh-melnacouzi sfc-gh-melnacouzi deleted the melnacouzi-add-release-channel-publish-command branch January 8, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants