[SNOW-1833500] New command: snow helpers import-snowsql-connections #1956
Conversation
sfc-gh-pjob
changed the title
…snowsql-config-migration-commands
| log.debug( | ||
| "Reading SnowSQL's connection configuration [%s] from [%s]", | ||
| snowsql_connection_section_name, | ||
| str(file.path), | ||
| ) |
There was a problem hiding this comment.
I would consider cli_console.step instead of debug. Imo showing users what is being read what is happening may be helpful in case of this command.
| raise ClickException( | ||
| f"Default connection name [{default_cli_connection_name}] conflicts with the name of one of connections from SnowSQL. Please specify a different name for your default connection." | ||
| ) |
There was a problem hiding this comment.
How about making this command more interactive? We error in case of connection/default names. In both cases we can prompt for user action instead of failing and requiring them to do some manual steps
Connection 'foo' exists in both configuration files, do you want to use SnowSQL definition? [y/N]
WDYT?
There was a problem hiding this comment.
I like the idea. I'd also consider --no-interactive or --skip-conflicting-connections so user can choose not to be prompted, but this might wait until someone actually requests it.
| key_names_replacements = { | ||
| "accountname": "account", | ||
| "username": "user", | ||
| "databasename": "database", | ||
| "dbname": "database", | ||
| "schemaname": "schema", | ||
| "warehousename": "warehouse", | ||
| "rolename": "role", | ||
| "private_key_path": "private_key_file", |
There was a problem hiding this comment.
Is this full list of options?
|
|
||
| def parse_value(value: Any): | ||
| try: | ||
| parsed_value = literal_eval(value) |
| custom_snowsql_config_files: Optional[List[Path]] = typer.Option( | ||
| None, | ||
| "--snowsql-config-file", | ||
| help="Specifies file paths to SnowSQL configuration. The option can be used multiple times to specify more than 1 file.", |
There was a problem hiding this comment.
| help="Specifies file paths to SnowSQL configuration. The option can be used multiple times to specify more than 1 file.", | |
| help="Specifies file paths to custom SnowSQL configuration. The option can be used multiple times to specify more than 1 file.", |
At first I thought that you need to provide default locations by hand :D
| imported_named_conenction = _convert_connection_from_snowsql_config_section( | ||
| snowsql_named_connection | ||
| ) | ||
| if connection_name in imported_named_connections: |
There was a problem hiding this comment.
Shouldn't we raise / prompt if connection is defined twice instead of overriding (or at least log console.step(connection redefined in X, overriding))
Pre-review checklist
Changes description
snow helpers import-snowsql-connections