Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline directly the default transparentImage #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dcorb
Copy link

@dcorb dcorb commented Oct 6, 2016

Great work. Maybe you consider this useful.

The default option "." results in a ajax request that most probably is a 404 page or HTML page.

Provide a useful and not broken experience by default. Specially for users who are using this library as drop-in-replacement, since then "transparentImage" was not part of the original library.

In our case, we use the library through https://www.drupal.org/project/cloud_zoom, so we can't access the original plugin js initialisation options.

Thanks

@smurfy
Copy link
Owner

smurfy commented Oct 6, 2016

Thank you, and you are half correct. Version 1.0.2 (which this fork is based on) had the "." as default. Which apparently the 1.0.3 fixes by providing a blank.gif

So i added the transparentImage option to overwrite this behaviour because all the 404 bugged me.

That said. It makes sense to change the default, because the default is stupid :)
I will merge this PR soon.

@dcorb
Copy link
Author

dcorb commented Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants