-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change pendingStepsRequest default queue size #16252
base: develop
Are you sure you want to change the base?
Conversation
I see you updated files related to
|
|
Part of: https://smartcontract-it.atlassian.net/browse/CAPPL-348
Reducing the pendingStepsRequest default queue size in engine.go accounts for 75% in the reduction in memory shown here, (which shoes a ~10 times reductions in memory usage)
https://docs.google.com/spreadsheets/d/1Hw9du-4K5obVLdrbso1nYKMQHDkbAvp8ulWq3wSkY64/edit?usp=sharing
The above results show that reducing the queue size from 100,000 to 1,000 does not have any impact on the workflow latency when running 200 workflows (in fact its a little better but not meaningfully so)