fix: generic generator on macos runners #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
requested review from
ianlewis,
laurentsimon,
joshuagl and
kpk47
as code owners
sgammon
force-pushed
the
fix/generator-macos-runner
branch
from
a2fe397 to
9875301
Compare
Fixes an issue with the `base64` call to generate subject data on macOS-based runners. Fixes and closes slsa-framework#3015. Signed-off-by: Sam Gammon <[email protected]>
laurentsimon
reviewed
Dec 4, 2023
actions/generator/generic/create-base64-subjects-from-file/action.yml
Outdated
Show resolved
Hide resolved
ianlewis
reviewed
Dec 5, 2023
Signed-off-by: Sam Gammon <[email protected]>
sgammon
force-pushed
the
fix/generator-macos-runner
branch
from
45d51e7 to
3d8b8ca
Compare
|
@ianlewis / @laurentsimon Thank you for the quick review! We are using this on our fork and all seems to be working fine. Here's a sample intoto signature produced from this revision buildless.darwin-amd64.intoto.jsonl.zip It was produced in a private pipeline, but published as part of this release. As far as I can tell, all seems good, but I'm rather new to SLSA. Thank you guys for all your hard work on this framework! |
ramonpetgrave64
added a commit
that referenced
this pull request
Mar 20, 2024
This reverts commit e092404.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the
base64call to generate subject data on macOS-based runners.Fixes and closes #3015.