-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): remove numpy strict installation from all extensions #1591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 7210170 in 1 minute and 9 seconds
More details
- Looked at
148
lines of code in9
files - Skipped
5
files when reviewing. - Skipped posting
11
drafted comments based on config settings.
1. extensions/connectors/sql/pyproject.toml:12
- Draft comment:
Removed numpy dependency. Ensure that no part of the SQL integration relies on numpy and that tests cover any indirect effects. - Reason this comment was not posted:
Comment did not seem useful: The comment asks the PR author to ensure that no part of the SQL integration relies on numpy and that tests cover any indirect effects. This violates the rule against asking the author to ensure behavior or test coverage. Additionally, it comments on a dependency change, which is not allowed.
2. extensions/connectors/yfinance/pyproject.toml:13
- Draft comment:
Removed strict numpy installation. Confirm that the YFinance integration functions as expected without it, and update tests if necessary. - Reason this comment was not posted:
Marked as duplicate.
3. extensions/llms/huggingface/pyproject.toml:14
- Draft comment:
Removed numpy dependency. Verify that this change doesn't affect any part of the Hugging Face integration and that tests cover any potential side effects. - Reason this comment was not posted:
Marked as duplicate.
4. extensions/llms/local/pyproject.toml:14
- Draft comment:
Removed numpy dependency. Ensure local LLM integration does not rely on numpy internally and that corresponding tests are updated. - Reason this comment was not posted:
Marked as duplicate.
5. extensions/sandbox/docker/pyproject.toml:11
- Draft comment:
Removed numpy dependency from the docker extension. Validate that this change does not affect the container's functionality and that tests reflect the update. - Reason this comment was not posted:
Comment did not seem useful: This comment is asking the PR author to validate the change and ensure tests reflect the update, which violates the rule against asking for confirmation or validation. Additionally, it comments on a dependency change, which is not allowed.
6. extensions/connectors/sql/pyproject.toml:12
- Draft comment:
Removed strict numpy dependency improves flexibility. Ensure that if numpy is required at runtime, a compatible version is documented or provided by the consumer environment. - Reason this comment was not posted:
Confidence changes required:33%
None
7. extensions/connectors/yfinance/pyproject.toml:13
- Draft comment:
Removed strict numpy version specification. Confirm that any numpy‐dependent logic works seamlessly with user-installed versions and document recommendations if needed. - Reason this comment was not posted:
Confidence changes required:33%
None
8. extensions/llms/huggingface/pyproject.toml:14
- Draft comment:
The strict numpy dependency has been removed here. Verify that any functionality requiring numpy remains compatible with a range of versions and update documentation if necessary. - Reason this comment was not posted:
Confidence changes required:33%
None
9. extensions/llms/local/pyproject.toml:14
- Draft comment:
Removed the strict numpy dependency from the Local LLM integration. It’s advisable to note any required numpy version in the documentation if the underlying code assumes its presence. - Reason this comment was not posted:
Confidence changes required:33%
None
10. extensions/sandbox/docker/pyproject.toml:11
- Draft comment:
The strict numpy dependency has been removed from the Docker extension. Please ensure that this does not affect functionality and update any related documentation if a specific numpy version is expected. - Reason this comment was not posted:
Confidence changes required:33%
None
11. extensions/connectors/sql/pyproject.toml:3
- Draft comment:
Version bump from 0.1.6 to 0.1.7 is appropriate. Please ensure that the changelog and documentation note the removal of the strict numpy dependency to inform users about this breaking change in dependency management. - Reason this comment was not posted:
Confidence changes required:33%
None
Workflow ID: wflow_rXO61A5KuSIyQCES
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1591 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 67 67
Lines 2488 2488
=======================================
Hits 2228 2228
Misses 260 260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Important
Removed strict
numpy
version constraints from several extensions and updated their version numbers.numpy
version constraints frompyproject.toml
insql
,yfinance
,huggingface
,local
, anddocker
extensions.pyproject.toml
forsql
to0.1.7
,yfinance
to0.1.4
,bedrock
to0.1.4
,google
to0.1.4
,huggingface
to0.1.4
,ibm
to0.1.4
,langchain
to0.1.4
,local
to0.1.4
, anddocker
to0.1.2
.This description was created by
for 7210170. It will automatically update as commits are pushed.