[Merged by Bors] - Add cargo vendor test #2076
Conversation
|
|
|
Thanks for the PR. As you already wrote, before we can merge this PR we need to fix the dependencies. Unfortunately we are blocked on some of those dependencies for the moment, see this issue: #1712. Hopefully we can resolve those as soon as possible and add in this test. |
## Issue Addressed resolves #2129 resolves #2099 addresses some of #1712 unblocks #2076 unblocks #2153 ## Proposed Changes - Updates all the dependencies mentioned in #2129, except for web3. They haven't merged their tokio 1.0 update because they are waiting on some dependencies of their own. Since we only use web3 in tests, I think updating it in a separate issue is fine. If they are able to merge soon though, I can update in this PR. - Updates `tokio_util` to 0.6.2 and `bytes` to 1.0.1. - We haven't made a discv5 release since merging tokio 1.0 updates so I'm using a commit rather than release atm. **Edit:** I think we should merge an update of `tokio_util` to 0.6.2 into discv5 before this release because it has panic fixes in `DelayQueue` --> PR in discv5: sigp/discv5#58 ## Additional Info tokio 1.0 changes that required some changes in lighthouse: - `interval.next().await.is_some()` -> `interval.tick().await` - `sleep` future is now `!Unpin` -> tokio-rs/tokio#3028 - `try_recv` has been temporarily removed from `mpsc` -> tokio-rs/tokio#3350 - stream features have moved to `tokio-stream` and `broadcast::Receiver::into_stream()` has been temporarily removed -> `tokio-rs/tokio#2870 - I've copied over the `BroadcastStream` wrapper from this PR, but can update to use `tokio-stream` once it's merged tokio-rs/tokio#3384 Co-authored-by: realbigsean <[email protected]>
bachp
force-pushed
the
cargo-vendor-test
branch
3 times, most recently
from
86d429e to
e1c1971
Compare
|
Looks like this is currently blocked by rust-lang/cargo#8443. Which prevents cargo vendor from running in Github Actions. |
bachp
force-pushed
the
cargo-vendor-test
branch
from
e1c1971 to
471c771
Compare
Perhaps we can work around this by just re-defining |
bachp
force-pushed
the
cargo-vendor-test
branch
from
732f934 to
ab9cab2
Compare
|
With the workaround of rust-lang/cargo#8443 (comment) the job is finally working, but there is an issue again that |
The test makes sure that the dependencies are in a state that can be vendored for archival and reproducibility purpose. cargo vendor is also used by several distros (e.g NixOS and Yocto) to archive the sources for the packages to be built.
bachp
force-pushed
the
cargo-vendor-test
branch
from
ab9cab2 to
5dd18be
Compare
|
In unstable the vendor issues are fixed. @paulhauner tests are now passing, so this is finally ready to be merged. |
## Issue Addressed This is related to #1926 and #1712. ## Proposed Changes This PR adds a test that make sure that the used dependencies can be vendored. Being able to vendor the dependencies is important for archival and repdroducibility purpose. It's also required to package lighthouse for some Linux distributions. Specifically [NixOS](https://nixos.org/) and [Yocto](https://www.yoctoproject.org/). ## Additional Info This PR only adds the test, it doesn't clean up the dependencies yet. That's why it is in draft.
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Issue Addressed
This is related to #1926 and #1712.
Proposed Changes
This PR adds a test that make sure that the used dependencies can be vendored.
Being able to vendor the dependencies is important for archival and repdroducibility purpose.
It's also required to package lighthouse for some Linux distributions. Specifically NixOS and Yocto.
Additional Info
This PR only adds the test, it doesn't clean up the dependencies yet. That's why it is in draft.