Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency cleanup prior to mainnet #1926

Closed
AgeManning opened this issue Nov 17, 2020 · 5 comments
Closed

Dependency cleanup prior to mainnet #1926

AgeManning opened this issue Nov 17, 2020 · 5 comments
Labels
A0 admin

Comments

@AgeManning
Copy link
Member

Description

We currently have in place a number of forks in non-canonical repositories which are required as the underlying dependencies have not updated to the latest ecosystem versions.

Along side this we have dependencies of varying versions and we should, where possible attempt to combine them all into a single version.

Before going to mainnet we should also update all dependencies to their latest version.

Specific forked deps that should be looked at are:

  • sigp/warp
  • sigp/unsigned_varint
  • sigp/rust-libp2p
@bachp
Copy link
Contributor

bachp commented Nov 25, 2020

While attempting to package lighthouse for NixOS I also run into issues with.

  • sigp/discv5 - which is included from git and not from crates.io
  • sigp/blst - which can't be properly cargo vendored when used from git

Cleaning these up would help.

@AgeManning
Copy link
Member Author

AgeManning commented Nov 26, 2020 •
edited
Loading

Yeah the discv5 dep is sorted in #1839 which will be merging to unstable within the next day.

I think the blst library has a new version we can target. @kirk-baird

@sean-sn
Copy link
Contributor

sean-sn commented Nov 26, 2020

Submitted #1979 which could be used to fix the blst problem.

@bachp
Copy link
Contributor

bachp commented Dec 10, 2020

Currently still an issue on unstable with cargo vendor:

  found duplicate version of package `headers v0.3.2` vendored from two sources:

        source 1: registry `https://github.com/rust-lang/crates.io-index`
        source 2: https://github.com/blacktemplar/headers?branch=lighthouse#8bffbd8a

@bachp bachp mentioned this issue Dec 10, 2020
Closed
@blacktemplar
Copy link
Contributor

I think we can close this issue as a duplicate of #1712, at least the three mentioned dependencies are all listed there too.

bors bot pushed a commit that referenced this issue Nov 5, 2021
@bachp
Add cargo vendor test (#2076)
2ed6775 
## Issue Addressed

This is related to #1926 and #1712.

## Proposed Changes

This PR adds a test that make sure that the used dependencies can be vendored.

Being able to vendor the dependencies is important for archival and repdroducibility purpose.
It's also required to package lighthouse for some Linux distributions. Specifically [NixOS](https://nixos.org/) and [Yocto](https://www.yoctoproject.org/).

## Additional Info

This PR only adds the test, it doesn't clean up the dependencies yet. That's why it is in draft.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A0 admin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bachp @blacktemplar @realbigsean @AgeManning @sean-sn