Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build-plugins): add test coverage for source map id injection #954

Merged
merged 5 commits into from
Feb 15, 2025

Conversation

mvirgil
Copy link

@mvirgil mvirgil commented Feb 14, 2025

Description

Created "integration" test within the build-plugins folder for testing behavior with real webpack

Added additional test cases to playwright test to verify that the snippet works properly to get sourceMapId onto the spans

Type of change

  • Chore or internal change (changes not visible to the consumers of the package)

How has this been tested?

  • Added unit tests
  • Added integration tests

Created "integration" test within the build-plugins folder for testing behavior
with real webpack

Added additional test cases to playwright test to verify that the snippet works
properly to get sourceMapId onto the spans
@mvirgil mvirgil marked this pull request as ready for review February 14, 2025 22:59
@mvirgil mvirgil requested review from a team as code owners February 14, 2025 22:59
@shumone shumone merged commit 7d02127 into signalfx:bundler-plugin Feb 15, 2025
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants