-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update brotli-size to 4.0.0 and get rid of iltorb #370
base: master
Are you sure you want to change the base?
Conversation
Hi maintainers! Is there any blockers to merge this PR? |
Hi! Checkout #320 (comment) |
Hi, I can't believe I have the same problem (about iltorb hard installation) and that you have an open PR on that !! But I can't use the bundlesize2 as I try to install antd package https://github.com/ant-design/ant-design/blob/master/package.json#L186 so I can only wait for your PR So I'm asking the same : Is there any blockers to merge this PR? Do you have any schedule for it ? I'm only waiting for it 😄 Thanks ! |
I also have issues with |
Hi @gracjan-sl! You might want to start using bundlesize2 that solves this issue: https://github.com/siddharthkp/bundlesize2#migration-from-bundlesize0180 |
Is there any blockers for this PR to be merged? I saw a sentence on
Does that mean until |
Pretty much, I'd recommend using bundlesize2, it solves for most of the use cases right now (not all). I understand it's not good open source behavior but it's the best I've got right now 😅 |
@siddharthkp what's the reason this PR can't be merged? We moved over to Thanks in advance |
This pulled in ancient versions of brotli-size (unlikely to be fixed: siddharthkp/bundlesize#370 (comment)) which broke CI on Node 20. IIUC, it shouldn’t even be needed anymore now that bundle size can be tested via BundleSizeTestBase instead; but in any case this can be figured out later, *after* CI is restored for the many extensions that pull in Popups. Bug: T382192 Bug: T360590 Change-Id: I86413a7707cbd33fd473f8a1daf6c7866fbb473f
* Update Popups from branch 'master' to 300e32b4d83070572812f094bd060dfd69d37362 - Kick bundlesize out of package.json This pulled in ancient versions of brotli-size (unlikely to be fixed: siddharthkp/bundlesize#370 (comment)) which broke CI on Node 20. IIUC, it shouldn’t even be needed anymore now that bundle size can be tested via BundleSizeTestBase instead; but in any case this can be figured out later, *after* CI is restored for the many extensions that pull in Popups. Bug: T382192 Bug: T360590 Change-Id: I86413a7707cbd33fd473f8a1daf6c7866fbb473f
This pulled in ancient versions of brotli-size (unlikely to be fixed: siddharthkp/bundlesize#370 (comment)) which broke CI on Node 20. IIUC, it shouldn’t even be needed anymore now that bundle size can be tested via BundleSizeTestBase instead; but in any case this can be figured out later, *after* CI is restored for the many extensions that pull in Popups. Bug: T382192 Bug: T360590 Change-Id: I86413a7707cbd33fd473f8a1daf6c7866fbb473f (cherry picked from commit 300e32b)
* Update extensions/Popups from branch 'wmf/1.44.0-wmf.6' to 25d940052d0ee5e8c6428fab934d2a2faba5baba - Kick bundlesize out of package.json This pulled in ancient versions of brotli-size (unlikely to be fixed: siddharthkp/bundlesize#370 (comment)) which broke CI on Node 20. IIUC, it shouldn’t even be needed anymore now that bundle size can be tested via BundleSizeTestBase instead; but in any case this can be figured out later, *after* CI is restored for the many extensions that pull in Popups. Bug: T382192 Bug: T360590 Change-Id: I86413a7707cbd33fd473f8a1daf6c7866fbb473f (cherry picked from commit 300e32b4d83070572812f094bd060dfd69d37362)
This pulled in ancient versions of brotli-size (unlikely to be fixed: siddharthkp/bundlesize#370 (comment)) which broke CI on Node 20. IIUC, it shouldn’t even be needed anymore now that bundle size can be tested via BundleSizeTestBase instead; but in any case this can be figured out later, *after* CI is restored for the many extensions that pull in Popups. Bug: T382192 Bug: T360590 Change-Id: I86413a7707cbd33fd473f8a1daf6c7866fbb473f (cherry picked from commit 300e32b)
This pulled in ancient versions of brotli-size (unlikely to be fixed: siddharthkp/bundlesize#370 (comment)) which broke CI on Node 20. IIUC, it shouldn’t even be needed anymore now that bundle size can be tested via BundleSizeTestBase instead; but in any case this can be figured out later, *after* CI is restored for the many extensions that pull in Popups. Bug: T382192 Bug: T360590 Change-Id: I86413a7707cbd33fd473f8a1daf6c7866fbb473f (cherry picked from commit 300e32b)
This pulled in ancient versions of brotli-size (unlikely to be fixed: siddharthkp/bundlesize#370 (comment)) which broke CI on Node 20. IIUC, it shouldn’t even be needed anymore now that bundle size can be tested via BundleSizeTestBase instead; but in any case this can be figured out later, *after* CI is restored for the many extensions that pull in Popups. Bug: T382192 Bug: T360590 Change-Id: I86413a7707cbd33fd473f8a1daf6c7866fbb473f (cherry picked from commit 300e32b)
This pulled in ancient versions of brotli-size (unlikely to be fixed: siddharthkp/bundlesize#370 (comment)) which broke CI on Node 20. IIUC, it shouldn’t even be needed anymore now that bundle size can be tested via BundleSizeTestBase instead; but in any case this can be figured out later, *after* CI is restored for the many extensions that pull in Popups. Bug: T382192 Bug: T360590 Change-Id: I86413a7707cbd33fd473f8a1daf6c7866fbb473f (cherry picked from commit 300e32b)
Description
Update brotli-size to 4.0.0 and get rid of iltorb 2.4.5 (getting 404 errors because some releases are removed from repo).
Types of changes