Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-ember from 7.13.0 to 10.5.1 #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps eslint-plugin-ember from 7.13.0 to 10.5.1.

Release notes

Sourced from eslint-plugin-ember's releases.

Release 10.5.1

🐛 Bug Fix

  • #1237 Stop using deprecated ESLint report API (@​bmish)
  • #1230 Use meta.hasSuggestions for suggestable rules to prepare for ESLint 8 (@​bmish)

📝 Documentation

  • #1241 Indicate which rules provide automated suggestions in README rules table (@​bmish)

🏠 Internal

  • #1222 Use ecmaVersion of 2020 internally for tests/linting (@​bmish)

Committers: 1

Release 10.5.0

🚀 Enhancement

🐛 Bug Fix

  • #1212 Improve detection of property names (check string literals in addition to identifiers) in several rules (@​bmish)
  • #1211 Fix false positive with non-components in require-tagless-components rule (@​bmish)
  • #1210 Avoid some false positives with lodash usage when recognizing extended Ember objects (@​bmish)
  • #1197 Check import when detecting controller usage in order-in-* rules (@​lin-ll)
  • #1196 Check import when detecting observer usage in order-in-* rules (@​lin-ll)

📝 Documentation

Committers: 2

Release 10.4.2

🐛 Bug Fix

  • #1195 Fix false positives with service/controller/observer detection in some rules (@​lin-ll)
  • #1187 Fix optional chaining support to handle newer ChainExpression implementation (@​bmish)
  • #1179 Handle spread syntax with both babel-eslint and @babel/eslint-parser parsers in order-in-* rules (@​bmish)

🏠 Internal

Committers: 2

Release 10.4.1

... (truncated)

Changelog

Sourced from eslint-plugin-ember's changelog.

v10.5.1 (2021-06-20)

🐛 Bug Fix

  • #1237 Stop using deprecated ESLint report API (@​bmish)
  • #1230 Use meta.hasSuggestions for suggestable rules to prepare for ESLint 8 (@​bmish)

📝 Documentation

  • #1241 Indicate which rules provide automated suggestions in README rules table (@​bmish)

🏠 Internal

  • #1222 Use ecmaVersion of 2020 internally for tests/linting (@​bmish)

Committers: 1

v10.5.0 (2021-05-30)

🚀 Enhancement

🐛 Bug Fix

  • #1212 Improve detection of property names (check string literals in addition to identifiers) in several rules (@​bmish)
  • #1211 Fix false positive with non-components in require-tagless-components rule (@​bmish)
  • #1210 Avoid some false positives with lodash usage when recognizing extended Ember objects (@​bmish)
  • #1197 Check import when detecting controller usage in order-in-* rules (@​lin-ll)
  • #1196 Check import when detecting observer usage in order-in-* rules (@​lin-ll)

📝 Documentation

Committers: 2

v10.4.2 (2021-05-13)

🐛 Bug Fix

  • #1195 Fix false positives with service/controller/observer detection in some rules (@​lin-ll)
  • #1187 Fix optional chaining support to handle newer ChainExpression implementation (@​bmish)
  • #1179 Handle spread syntax with both babel-eslint and @babel/eslint-parser parsers in order-in-* rules (@​bmish)

🏠 Internal

... (truncated)

Commits
  • 2954fca Release 10.5.1
  • aa8bd61 Merge pull request #1241 from bmish/docs-suggestions-readme-rules
  • e779c8b docs: Mention rules that provide automated suggestions in README rules table
  • c339ddf Merge pull request #1239 from ember-cli/dependabot/npm_and_yarn/eslint-7.29.0
  • 4bac832 Merge pull request #1240 from ember-cli/dependabot/npm_and_yarn/eslint-plugin...
  • 4c1a42e build(deps-dev): bump eslint-plugin-eslint-plugin from 3.0.3 to 3.1.0
  • 30f7c44 build(deps-dev): bump eslint from 7.28.0 to 7.29.0
  • 48a5d33 Merge pull request #1237 from bmish/deprecated-report-api
  • 473a816 fix: stop using deprecated report API
  • 6559ca5 Merge pull request #1235 from ember-cli/dependabot/npm_and_yarn/babel/plugin-...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jun 22, 2021
@pull-request-quantifier-deprecated

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.json : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants