Feat/#159 WorkspaceMember의 id를 기록하는 WebRequestAuditorAware 구현
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존에는 세션에서 로그인 Member의 id를 기록 - 워크스페이스와 관련된 행위에 대해서는 WorkspaceMember의 id 기록이 필요 - AuthorizationInterceptor에서 현재 WorkspaceMember id를 HttpServletRequest에 저장 - 이름 변경 SessionAuditorAware -> WebRequestAuditorAware - 요청의 API URI를 읽어서 /api/v1/workspaces로 시작하면 request에서 workspaceMemberId 읽음 - 워크스페이스 생성의 경우 그냥 Member의 id 기록 - Workspace의 경우 WorkspaceBaseEntity 상속 - 생성자: createdByMember - 수정자: lastModifiedByWorkspaceMember - Workspace와 관련된 엔티티의 경우 WorkspaceContextBaseEntity 상속 - 생성자: createdByWorkspaceMember - 수정자: lastModifiedByWorkspaceMember - 워크스페이스와 관련 없는 엔티티(Member)의 경우 BaseEntity 상속 - 생성자: createdByMember - 수정자: lastModifiedByMember
- 필요 없는 코드임
📊 Test Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 설명
WorkspaceMember의id기록이 필요AuthorizationInterceptor에서 현재WorkspaceMember의id를HttpServletRequest에 저장SessionAuditorAware->WebRequestAuditorAware/api/v1/workspaces로 시작하면HttpServletRequest에서 속성에 저장한 현재WorkspaceMember의id를 읽음/api/v1/workspaces로 시작하는 요청이 아니면, 기존 처럼 세션에서Member의id를 읽어서 반환Member의id기록Workspace의 경우WorkspaceBaseEntity상속createdByMemberlastModifiedByWorkspaceMemberWorkspace와 관련된 엔티티의 경우WorkspaceContextBaseEntity상속createdByWorkspaceMemberlastModifiedByWorkspaceMemberMember)의 경우BaseEntity상속createdByMemberlastModifiedByMember✅ 변경 사항
SessionAuditorAware->WebRequestAuditorAwareAuthorizationInterceptor에서 현재 요청에 대한WorkspaceMember의id를HttpServletRequest에 저장🚩 관련 이슈, PR
WebRequestAuditorAware를 구현한다 #159📖 참고