Skip to content
This repository has been archived by the owner on Jan 31, 2025. It is now read-only.

Surface supported interaction profiles from OpenXR runtime #229

Merged
merged 7 commits into from
Jul 26, 2024

Conversation

msub2
Copy link
Contributor

@msub2 msub2 commented Jul 24, 2024

This introduces support for a wider range of OpenXR interaction profiles and properly handles updating the associated XRInputSource when the active interaction profile changes.

@msub2
Copy link
Contributor Author

msub2 commented Jul 24, 2024

Leaving this as a draft right now while I wait on some word from ralith/openxrs#228

Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

webxr/openxr/input.rs Outdated Show resolved Hide resolved
webxr/openxr/interaction_profiles.rs Outdated Show resolved Hide resolved
webxr/openxr/input.rs Outdated Show resolved Hide resolved
webxr/openxr/input.rs Outdated Show resolved Hide resolved
@msub2 msub2 marked this pull request as ready for review July 26, 2024 04:01
@msub2 msub2 requested a review from jdm July 26, 2024 04:01
@msub2
Copy link
Contributor Author

msub2 commented Jul 26, 2024

ah whoops there's a typo in the touch plus profile still, fixing

@jdm jdm added this pull request to the merge queue Jul 26, 2024
Merged via the queue into servo:main with commit 89d7027 Jul 26, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants