This repository has been archived by the owner on Aug 18, 2022. It is now read-only.
junit cleanup to make useable with cucumber-junit-platform-engine #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to CucumberWithSerenityRuntime
nicerloop
changed the title
wakaleo
reviewed
Sep 13, 2021
| @@ -896,7 +895,7 @@ private boolean errorOrFailureRecordedForStep(String stepTitle, Throwable cause) | |||
| } | |||
|
|
|||
| private boolean isAssumptionFailure(Throwable rootCause) { | |||
| return (AssumptionViolatedException.class.isAssignableFrom(rootCause.getClass())); | |||
| return ("org.junit.internal.AssumptionViolatedException".equals(rootCause.getClass().getCanonicalName())); | |||
There was a problem hiding this comment.
These statements are not equivalent though - the class may also be derived from org.junit.internal.AssumptionViolatedException
There was a problem hiding this comment.
Yes, better use Class.forName with a try-catch block.
…nViolatedException
|
Obsoleted by serenity-bdd/serenity-core#2648 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to use serenity with cucumber-junit-platform-engine. This applies equally to serenity-cucumber5 and serenity-cucumber6, as the assumption that cucumber scenarios are launched from junit4 still holds and creates exactly the same problems.
I have published a reproduction example: https://github.com/nicerloop/serenity-cucumber-starter/tree/use-cucumber-junit-platform-engine
#35