Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version_utils:is_enterprise()) don't match for 2025.1 and above #9995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaronkaikov
Copy link
Contributor

@yaronkaikov yaronkaikov commented Feb 5, 2025

artifacts-centos9-web-test failed with the following error:

Command: 'curl -sSf get.scylladb.com/server | sudo bash -s -- --scylla-version nightly-2025.1 --scylla-product scylla-enterprise'
Exit code: 1
Stdout:
Installing Scylla version nightly-2025.1 for CentOS ...
The specified scylla-version 'nightly-2025.1' has reached End of Life (EOL) or not available.
• For OSS supported ScyllaDB versions please refer to https://docs.scylladb.com/stable/getting-started/os-support
• For Enterprise supported ScyllaDB versions please refer to https://enterprise.docs.scylladb.com/stable/getting-started/os-support

modifing is_enterprise() to return true only for 2024.X

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

artifacts-centos9-web-test failed with the following error:
```
Command: 'curl -sSf get.scylladb.com/server | sudo bash -s -- --scylla-version nightly-2025.1 --scylla-product scylla-enterprise'
Exit code: 1
Stdout:
Installing Scylla version nightly-2025.1 for CentOS ...
The specified scylla-version 'nightly-2025.1' has reached End of Life (EOL) or not available.
• For OSS supported ScyllaDB versions please refer to https://docs.scylladb.com/stable/getting-started/os-support
• For Enterprise supported ScyllaDB versions please refer to https://enterprise.docs.scylladb.com/stable/getting-started/os-support
```

modifing is_enterprise() to return true only for 2024.X
@pehala
Copy link
Contributor

pehala commented Feb 5, 2025

I worry this will have further consequences, as I believe we depend on this function for Nemesis as well.

I would rather remove usage of scylla-enterprise product in this particular query, though I am not sure if it wont cause problems for upgrades from older versions

Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_enterprise method is used in many places, probably this change will break many tests, including unit tests, upgrade, features tests (for which 2025.1 is considered as enterprise) and possibly more.

If it breaks only this web test, let's hardcode product_type in web_install_scylla.
When updating commit, please follow rules:

00:05:16.221  ✖   subject may not be empty [subject-empty]
00:05:16.221  ✖   type may not be empty [type-empty]
00:05:16.221  ✖   scope may not be empty [scope-empty]
00:05:16.221  ✖   body's lines must not be longer than 120 characters [body-max-line-length]

without fruch, we won't be able to merge due merge restrictions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants