fix(DecommissionStreamingErr): new log lines added #9978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtimb0t
force-pushed
the
decommission_log_lines
branch
from
6e0c08e to
fdad7a0
Compare
timtimb0t
changed the title
timtimb0t
force-pushed
the
decommission_log_lines
branch
from
fdad7a0 to
d9f0656
Compare
aleksbykov
reviewed
Feb 11, 2025
sdcm/utils/raft/__init__.py
Outdated
Comment on lines
53
to
58
| MessagePosition("api - decommission", LogPosition.BEGIN), | ||
| MessagePosition("DECOMMISSIONING: unbootstrap starts", LogPosition.BEGIN), | ||
| MessagePosition("DECOMMISSIONING: unbootstrap done", LogPosition.END), | ||
| MessagePosition("becoming a group 0 non-voter", LogPosition.END), | ||
| MessagePosition("became a group 0 non-voter", LogPosition.END), | ||
| MessagePosition("leaving token ring", LogPosition.END), | ||
| MessagePosition("left token ring", LogPosition.END), | ||
| MessagePosition("raft_topology - decommission: waiting for completion", LogPosition.BEGIN), | ||
| MessagePosition("repair - decommission_with_repair", LogPosition.END) | ||
| MessagePosition("repair - decommission_with_repair", LogPosition.END), | ||
| MessagePosition("raft_topology - request decommission for", LogPosition.BEGIN), | ||
| MessagePosition("storage_service - Started batchlog replay for decommission", LogPosition.BEGIN), | ||
| MessagePosition("storage_service - Finished batchlog replay for decommission", LogPosition.BEGIN), |
There was a problem hiding this comment.
add please these lines also:
- raft_topology - start streaming
- raft_topology - streaming completed
- raft_topology - decommission: successfully removed from topology
- raft_topology - Decommission succeeded
sdcm/utils/raft/__init__.py
Outdated
Comment on lines
53
to
58
| MessagePosition("api - decommission", LogPosition.BEGIN), | ||
| MessagePosition("DECOMMISSIONING: unbootstrap starts", LogPosition.BEGIN), | ||
| MessagePosition("DECOMMISSIONING: unbootstrap done", LogPosition.END), | ||
| MessagePosition("becoming a group 0 non-voter", LogPosition.END), | ||
| MessagePosition("became a group 0 non-voter", LogPosition.END), | ||
| MessagePosition("leaving token ring", LogPosition.END), | ||
| MessagePosition("left token ring", LogPosition.END), | ||
| MessagePosition("raft_topology - decommission: waiting for completion", LogPosition.BEGIN), | ||
| MessagePosition("repair - decommission_with_repair", LogPosition.END) | ||
| MessagePosition("repair - decommission_with_repair", LogPosition.END), | ||
| MessagePosition("raft_topology - request decommission for", LogPosition.BEGIN), | ||
| MessagePosition("storage_service - Started batchlog replay for decommission", LogPosition.BEGIN), | ||
| MessagePosition("storage_service - Finished batchlog replay for decommission", LogPosition.BEGIN), |
There was a problem hiding this comment.
This one MessagePosition("storage_service - Finished batchlog replay for decommission", LogPosition.BEGIN), i think not needed
aleksbykov
added
backport/2024.2
for aborting the decommission process fixes:9501
timtimb0t
force-pushed
the
decommission_log_lines
branch
from
d9f0656 to
300c259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new log lines added for aborting the decommission process
fixes: #9501
Testing
https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/eugene_test_folder/job/decommission_logs_testing/
https://argus.scylladb.com/tests/scylla-cluster-tests/d4151c1d-bce7-4689-91f4-67269dc2ef44
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)