Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gh-actions): Make docker and release actions work #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vponomaryov
Copy link
Collaborator

Fixes:

  • Before docker ARM image building was failing running in Qemu. Now it gets build on a dedicated ARM-based runner. After both builds (amd, arm) are completed we create manifest refering to the built digest/sha256 of both images.
  • Before we were trying to create release from 2 artifact builders it was racing and second one was failing the pipeline.
  • Also, before it was not expected that release may exist. Redo logic to allow a release be created as well as it's tag.

TODO:

  • fix getting of upload URL

Fixes:
- Before docker ARM image building was failing running in Qemu.
  Now it gets build on a dedicated ARM-based runner.
  After both builds (amd, arm) are completed we create manifest
  refering to the built digest/sha256 of both images.
- Before we were trying to create release from 2 artifact builders
  it was racing and second one was failing the pipeline.
- Also, before it was not expected that release may exist.
  Redo logic to allow a release be created as well as it's tag.

TODO:
- fix getting of upload URL
@vponomaryov
Copy link
Collaborator Author

vponomaryov commented Feb 8, 2025

Images, AMD and ARM, were created here: https://hub.docker.com/r/scylladb/hydra-loaders/tags?name=latte

Screenshot:
Screenshot from 2025-02-08 10-17-54

Those images were created exactly by these github actions.
It was created there because I have "write" creds there using my account.
TODO: need to make our QA docker user have "read/write" access to the "scylladb/latte" docker registry/repo.

Github action results which built those images are here: https://github.com/scylladb/latte/actions/runs/13213653580/job/36890378335

As it is written above, left to fix getting of the "upload url" for uploading built binaries.

@fruch , @CodeLieutenant do we really want to compile binaries and attach it to releases?
I am asking just because I am aware about cases where some people use either docker or compile themselves.
Since these binaries depend on system libraries the compilation in place sounds reasonable.

Time notes:

  • The docker AMD image build takes about 4m30s
  • The docker ARM image build takes about 5m50s
  • Binary compilation for ubuntu-22.04 on AMD takes about 3m50s.
  • Other binaries compilation takes more.

So, do we want to double the spent time for building binaries which are unknown to be used by anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant