make slack/sentry imports optional

scrapinghub · Feb 7, 2025 · e701ff0 · e701ff0
1 parent 05e8bfb
commit e701ff0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/shub_workflow/contrib/sentry.py b/shub_workflow/contrib/sentry.py
@@ -2,8 +2,6 @@
 from pprint import pformat
 from typing import Dict, Any
 
-from spidermon.contrib.actions.sentry import SendSentryMessage
-
 from shub_workflow.utils import resolve_shub_jobkey
 from shub_workflow.utils.alert_sender import AlertSenderMixin
 
@@ -18,6 +16,10 @@ class SentryMixin(AlertSenderMixin):
 
     def __init__(self):
         super().__init__()
+        try:
+            from spidermon.contrib.actions.sentry import SendSentryMessage
+        except ImportError:
+            raise ImportError("spidermon[sentry-sdk] is required for using SentryMixin.")
         self.sentry_handler = SendSentryMessage(
             fake=self.project_settings.getbool("SPIDERMON_SENTRY_FAKE"),
             sentry_dsn=self.project_settings.get("SPIDERMON_SENTRY_DSN"),

diff --git a/shub_workflow/contrib/slack.py b/shub_workflow/contrib/slack.py
@@ -2,8 +2,6 @@
 from pprint import pformat
 from typing import Any, Dict, List
 
-from spidermon.contrib.actions.slack import SlackMessageManager
-
 from shub_workflow.utils import resolve_shub_jobkey
 from shub_workflow.utils.alert_sender import AlertSenderMixin
 
@@ -13,6 +11,10 @@
 class SlackSender:
     def __init__(self, project_settings):
         super().__init__()
+        try:
+            from spidermon.contrib.actions.slack import SlackMessageManager
+        except ImportError:
+            raise ImportError("spidermon[slack-sdk] is required for using SlackSender")
         self.slack_handler = SlackMessageManager(
             fake=project_settings.getbool("SPIDERMON_SLACK_FAKE"),
             sender_token=project_settings.get("SPIDERMON_SLACK_SENDER_TOKEN"),