Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark awkward as freedthread safe with pybind11 #3396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Feb 7, 2025

Fixes: #3395

Need to create some tests that demonstrate this is, in fact, the case.

@lgray
Copy link
Contributor Author

lgray commented Feb 9, 2025

My understanding of the C component of awkward array is that it is already reentrant and carries no state.
So I think this is safe to do without adding tests aside from the usual tests in python 3.13t (which is soon to be available through actions).

I am thinking about the python side of awkward and there are not many situations where you'd be manipulating array metadata in a reentrant way, no structure we can make is large enough to need it. Typically multithreaded work on awkward arrays is going to be at the numpy level.

The only place where there might be some issues is with typetracers, but the this is a fairly ill-defined worry.

My gut feeling is that we don't really need to do too much to merge this.

@lgray lgray marked this pull request as ready for review February 9, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awkward-cpp needs to declare that it can be run freethreaded!
1 participant