fix: record calls to constructors in lambdaLift #22487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
odersky
reviewed
Feb 17, 2025
| if sym.is(Method) | ||
| then deps.logicalOwner.getOrElse(sym, sym.enclosure) | ||
| else sym.enclosure | ||
| deps.logicalOwner.getOrElse(sym, sym.enclosure) |
There was a problem hiding this comment.
Why was the isMethod test dropped?
There was a problem hiding this comment.
This was just my previous approach for solving this issue, so this is basically a revert. Turns out that picking the enclosure (if there is a logicalOwner set) here just isn't correct in some cases.
odersky
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possible fix for #21931 #22470
Attempt no. 2 for #21931