Implement summonIgnoring
#22417
Draft
Implement summonIgnoring
#22417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we do this, I think this functionality should be also in |
|
It's actually macros-only for now, but of course users could just prepare their own macro method that summons what they want and returns it for use elsewhere |
Gedochao
added
the
needs-minor-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion: #21909
We have yet to confirm/discuss whether this should/can be merged, but otherwise I consider this a complete implementation.
One thing to note - I decided it would be better for the
ignoredlist to not affect indirect implicit searches (like in thetests/run-macros/summonIgnoring-nonrecursivetest.