Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with ScalaJs release badge #678

Closed
wants to merge 1 commit into from

Conversation

joriscode
Copy link

I think having ScalaJs badge would highlight that ScalaJs is supported.

@SethTisue
Copy link
Member

mind signing the Scala CLA?

@SethTisue
Copy link
Member

SethTisue commented Jan 27, 2025

(after some thought)

The concern about appearing to be JVM-only is valid, definitely.

But I'm wondering if we want to just rid of the JVM badge altogether, rather than add more badges.

I think these badges (and the related practice of putting the current version number in the README directly) got started in an era when the GitHub web UI wasn't very good at surfacing the library's current version number. These days, the GitHub UI does a better job of that:

Screenshot 2025-01-27 at 10 20 30 AM

So there was sort of an era of badges, which I feel has now passed. At least, that's my own subjective impression.

@SethTisue
Copy link
Member

Note also that we published 2.13.0 an hour or two ago, but the badge still says 2.12.0, I guess because Scaladex takes time to update. (How much time — hours, days? I don't know.)

@joriscode
Copy link
Author

Note also that we published 2.13.0 an hour or two ago, but the badge still says 2.12.0, I guess because Scaladex takes time to update. (How much time — hours, days? I don't know.)

(One hour later) It is up-to-date now :)

But I'm wondering if we want to just rid of the JVM badge altogether, rather than add more badges.

On the bright side, it demonstrates the different targets (JVM, JS, Native), but this comes with the downside that a third badge should be added for Scala Native. It is up-to-you.

@SethTisue
Copy link
Member

SethTisue commented Jan 27, 2025

Tell you what, I'll submit a different PR that removes the badge, but also adds a bit to the readme that emphasizes that JVM, Scala.js, and Scala Native are all supported.

Thank you for bringing this up.

@SethTisue SethTisue closed this Jan 27, 2025
@SethTisue SethTisue mentioned this pull request Jan 27, 2025
@SethTisue
Copy link
Member

#680

@joriscode joriscode deleted the patch-1 branch January 28, 2025 08:00
@joriscode
Copy link
Author

That works for me and thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants