Drain response bodies before retrying #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.84% // Head: 90.84% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2987 +/- ##
=======================================
Coverage 90.84% 90.84%
=======================================
Files 160 160
Lines 3298 3298
Branches 314 314
=======================================
Hits 2996 2996
Misses 302 302
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fthomas
approved these changes
Feb 25, 2023
There was a problem hiding this comment.
Thanks @armanbilge!
@daddykotex It would be nice to know if this fixes the error you reported in the http4s-jdk-http-client issue.
|
Last docker tag was build on: Looking at the stack, we may be looking at a different problem. |
|
Thanks for trying that! It may be that we need to drain the body in some other places as well.
Well, these kinds of issues are tricky to track down. In my experience usually it's the request before the request that appears to fail that has gone wrong. e.g. one request succeeds but corrupts the connection, the one after it goes wrong. |
|
The stack trace also includes |
|
Today, the stack was a little bit different: Ran on: |
|
I'm starting to think that the reason we see this error is due to rate limiting (but I'm not sure because after we see the error, the instance continues to create other PRs in other repos...). When you look at the docs for rate limiting it is specified that we can read:
Right after that, there is an example of response when rate limiting occurs: We can see two things: |
|
Not sure about the connection to HTTP/2. The stack traces above are both mentioning HTTP/1 related classes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for http4s/http4s-jdk-http-client#714 (comment). Hopefully :)