-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(API): sbpp_checker library name #1034
base: php81
Are you sure you want to change the base?
Conversation
Is this ready for review, or still draft? |
Draft. I need to edit it later today. |
@rumblefrog Ready to be merged with a squash commit. |
Hello @rumblefrog any input? |
I will remind myself to take a look when I can, but if it looks good to you, you can stamp it. |
@@ -29,7 +29,7 @@ | |||
|
|||
#include <sourcemod> | |||
|
|||
#define VERSION "1.8.3" | |||
#define VERSION "1.8.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if breaking, should we update major, or how do we communicate it in our versioning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
major if its breaking imo so that we avoid any confusion
Description
Fix library name conflict between
sbpp_checker
andsbpp_main
(both were usingsourcebans++
)sbpp_main
keepssourcebans++
sbpp_checker
now usessourcebanspp_checker
This allows proper verification of specific libraries via
LibraryExists
and avoids any confusion between the two plugins.Description
The main issue is a library name conflict where both sbpp_checker and sbpp_main were using the same name "sourcebans++" when registering their library via
RegPluginLibrary
. This was causing problems when checking for library existence withLibraryExists
.Motivation and Context
LibraryExists
withsourcebans++
for using sbpp checker natives, wich was always incorrect to due the sameRegPluginLibrary
as sbpp_main.How Has This Been Tested?
Tested with a test plugin implementing all new forwards:
Screenshots (if appropriate):
Types of changes
Checklist: