Use a modal #38
Open
Use a modal #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Increase the top and bottom padding on the modal to match the left and right padding * Add a missing span and remove a useless p
The tip dialog finally feels like it belongs!
# Conflicts: # css/style.css # js/graph.js
# Conflicts: # index.html # js/graph.js
…odal # Conflicts: # index.html # js/graph.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a modal we get more screen real-estate for the graph, and also get to remove the hacky canvas resize code and custom input widths. It also looks cooler(TM), at least in my opinion.
Bootstrap was added as a dependency, but we're not using any of its JavaScript plugins (yet). I'll experiment with the modal plugin later.