Fixed that AddCheckListItemAsync did not use NamedPosition

rwjdk · Nov 29, 2024 · baedd95 · baedd95
1 parent 2d5a71a
commit baedd95
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -1,6 +1,12 @@
 # Changelog 
 *Below is the version history of [TrelloDotNet](https://github.com/rwjdk/TrelloDotNet) (An wrapper of the Trello API)*
 
+## 1.11.5 (29th of November 2024)
+#### TrelloClient
+- Fix that [AddChecklistItemAsync](https://github.com/rwjdk/TrelloDotNet/wiki/AddChecklistItemAsync) did not use the NamedPosition Property
+
+<hr/>
+
 ## 1.11.4 (25th of November 2024)
 #### TrelloClient
 - Added [AddChecklistItemAsync](https://github.com/rwjdk/TrelloDotNet/wiki/AddChecklistItemAsync)

diff --git a/src/TrelloDotNet/TrelloClient.Checklists.cs b/src/TrelloDotNet/TrelloClient.Checklists.cs
@@ -67,7 +67,9 @@ public async Task<Checklist> AddChecklistAsync(string cardId, Checklist checklis
         /// <returns>The new Checklist Item</returns>
         public async Task<ChecklistItem> AddChecklistItemAsync(string checklistId, ChecklistItem checkItemToAdd, CancellationToken cancellationToken = default)
         {
-            return await _apiRequestController.Post<ChecklistItem>($"{UrlPaths.Checklists}/{checklistId}/{UrlPaths.CheckItems}", cancellationToken, _queryParametersBuilder.GetViaQueryParameterAttributes(checkItemToAdd));
+            var parameters = _queryParametersBuilder.GetViaQueryParameterAttributes(checkItemToAdd);
+            _queryParametersBuilder.AdjustForNamedPosition(parameters, checkItemToAdd.NamedPosition);
+            return await _apiRequestController.Post<ChecklistItem>($"{UrlPaths.Checklists}/{checklistId}/{UrlPaths.CheckItems}", cancellationToken, parameters);
         }
 
         internal async Task AddCheckItemsAsync(Checklist existingChecklist, params ChecklistItem[] checkItemsToAdd)

diff --git a/src/TrelloDotNet/TrelloDotNet.csproj b/src/TrelloDotNet/TrelloDotNet.csproj
@@ -13,7 +13,7 @@
 		<PackageProjectUrl>https://github.com/rwjdk/TrelloDotNet/wiki</PackageProjectUrl>
 		<PackageIcon>trello.png</PackageIcon>
 		<PackageTags>trello api rest .NET dotNet crud wrapper webhook automation</PackageTags>
-		<Version>1.11.4</Version>
+		<Version>1.11.5</Version>
 		<Company>RWJDK</Company>
 		<PublishRepositoryUrl>true</PublishRepositoryUrl>
 		<IncludeSymbols>true</IncludeSymbols>