Fixed Name error (missing Async suffix)

rwjdk · Nov 2, 2024 · 7466589 · 7466589
1 parent a78e0b1
commit 7466589
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -1,6 +1,11 @@
 # Changelog 
 *Below is the version history of [TrelloDotNet](https://github.com/rwjdk/TrelloDotNet) (An wrapper of the Trello API)*
 
+## 1.11.4 (3rd of November 2024)
+- Renamed `DownloadAttachment` to [DownloadAttachmentAsync](https://github.com/rwjdk/TrelloDotNet/wiki/DownloadAttachmentAsync)
+
+<hr/>
+
 ## 1.11.3 (3rd of November 2024)
 #### TrelloClient
 - Added [GetAttachmentOnCardAsync](https://github.com/rwjdk/TrelloDotNet/wiki/GetAttachmentOnCardAsync)

diff --git a/src/TrelloDotNet/TrelloClient.Attachments.cs b/src/TrelloDotNet/TrelloClient.Attachments.cs
@@ -109,10 +109,10 @@ public async Task<Attachment> AddAttachmentToCardAsync(string cardId, Attachment
         /// <param name="attachmentId">Id of Attachment</param>
         /// <param name="cancellationToken">Cancellation Token</param>
         /// <returns></returns>
-        public async Task<Stream> DownloadAttachment(string cardId, string attachmentId, CancellationToken cancellationToken = default)
+        public async Task<Stream> DownloadAttachmentAsync(string cardId, string attachmentId, CancellationToken cancellationToken = default)
         {
             Attachment attachment = await GetAttachmentOnCardAsync(cardId, attachmentId, cancellationToken);
-            return await DownloadAttachment(attachment.Url, cancellationToken);
+            return await DownloadAttachmentAsync(attachment.Url, cancellationToken);
         }
 
         /// <summary>
@@ -121,7 +121,7 @@ public async Task<Stream> DownloadAttachment(string cardId, string attachmentId,
         /// <param name="url">URL of the attachment</param>
         /// <param name="cancellationToken">Cancellation Token</param>
         /// <returns></returns>
-        public async Task<Stream> DownloadAttachment(string url, CancellationToken cancellationToken = default)
+        public async Task<Stream> DownloadAttachmentAsync(string url, CancellationToken cancellationToken = default)
         {
             try
             {

diff --git a/src/TrelloDotNet/TrelloDotNet.csproj b/src/TrelloDotNet/TrelloDotNet.csproj
@@ -13,7 +13,7 @@
 		<PackageProjectUrl>https://github.com/rwjdk/TrelloDotNet/wiki</PackageProjectUrl>
 		<PackageIcon>trello.png</PackageIcon>
 		<PackageTags>trello api rest .NET dotNet crud wrapper webhook automation</PackageTags>
-		<Version>1.11.3</Version>
+		<Version>1.11.4</Version>
 		<Company>RWJDK</Company>
 		<PublishRepositoryUrl>true</PublishRepositoryUrl>
 		<IncludeSymbols>true</IncludeSymbols>