Appease clippy #259
Merged
Appease clippy #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
approved these changes
Jan 28, 2025
MarijnS95
reviewed
Jan 28, 2025
| @@ -100,6 +100,7 @@ jobs: | |||
| run: | | |||
| cargo update -p ahash --precise 0.8.7 | |||
| cargo update -p bumpalo --precise 3.14.0 | |||
| cargo update -p objc2-encode --precise 4.0.3 | |||
There was a problem hiding this comment.
Suggestion to see if we can run cargo +nightly -Zminimal-versions generate-lockfile before doing an MSRV test? I've been doing that on all my repositories and it at the same time ensures the lower bound of all my dependencies are correct/buildable :)
(Assuming there aren't too many different combinations / features / optional dependencies to test, of course)
There was a problem hiding this comment.
For my part, feel free to try! I only did this now to fix CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DRM example failing in CI here.
Also pins
objc2-encodefor the MSRV CI check (will be redundant after #254).