Update objc2
to v0.6
, and use new objc2-core-graphics
crate
#254
+146
−89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objc2
now provides an interface to CoreGraphics, which has automatic memory management, and interfaces better with the otherobjc2-*
crates. Note that this doesn't have, but I'd argue that's actually a benefit, since it forces us to implement the data provider ourselves (and makes it very visible that that's a place where there's room for improvement).Another notable change is the introduction of
Retained::downcast
, which we use to ensure that our types are correct in the key-value observer (instead of blindly casting, and hoping that they are).This requires an MSRV bump to Rust 1.71 to get access to
extern "C-unwind"
functions.