Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn about broken simd not only on structs but also enums and unions when we didn't opt in to it #135219

Merged
merged 1 commit into from
Jan 8, 2025
Merged

warn about broken simd not only on structs but also enums and unions when we didn't opt in to it #135219

merged 1 commit into from
Jan 8, 2025
+67 −9

Conversation

matthiaskrgr
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 7, 2025
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 7, 2025

📌 Commit b9d6e9e has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2025
@matthiaskrgr
Rollup merge of rust-lang#135219 - matthiaskrgr:simd'nt, r=compiler-e…
846a9c4 
…rrors

warn about broken simd not only on structs but also enums and unions when we didn't opt in to it

addresses rust-lang#135208 (comment)

r? `@Noratrieb`
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 8, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2025
@bors
Auto merge of rust-lang#135227 - matthiaskrgr:rollup-5itqccr, r=matth…
ea70a41 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#134389 (Condvar: implement wait_timeout for targets without threads)
 - rust-lang#134920 (Convert typeck constraints in location-sensitive polonius)
 - rust-lang#135032 (triagebot: register `relnotes-interest-group` ping group)
 - rust-lang#135176 (More compelling env_clear() examples)
 - rust-lang#135184 (Reserve x18 register for aarch64 wrs vxworks target)
 - rust-lang#135203 (arm: add unstable soft-float target feature)
 - rust-lang#135219 (warn about broken simd not only on structs but also enums and unions when we didn't opt in to it)

r? `@ghost`
`@rustbot` modify labels: rollup
@jhpratt jhpratt mentioned this pull request Jan 8, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2025
@bors
Auto merge of rust-lang#135227 - matthiaskrgr:rollup-5itqccr, r=<try>
f5007e1 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#134389 (Condvar: implement wait_timeout for targets without threads)
 - rust-lang#134920 (Convert typeck constraints in location-sensitive polonius)
 - rust-lang#135032 (triagebot: register `relnotes-interest-group` ping group)
 - rust-lang#135176 (More compelling env_clear() examples)
 - rust-lang#135184 (Reserve x18 register for aarch64 wrs vxworks target)
 - rust-lang#135203 (arm: add unstable soft-float target feature)
 - rust-lang#135219 (warn about broken simd not only on structs but also enums and unions when we didn't opt in to it)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: i686-mingw
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2025
@bors
Auto merge of rust-lang#135234 - jhpratt:rollup-4gvvo4y, r=jhpratt
9c87288 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#133057 (Impl String::into_chars)
 - rust-lang#134389 (Condvar: implement wait_timeout for targets without threads)
 - rust-lang#134920 (Convert typeck constraints in location-sensitive polonius)
 - rust-lang#135032 (triagebot: register `relnotes-interest-group` ping group)
 - rust-lang#135176 (More compelling env_clear() examples)
 - rust-lang#135184 (Reserve x18 register for aarch64 wrs vxworks target)
 - rust-lang#135203 (arm: add unstable soft-float target feature)
 - rust-lang#135219 (warn about broken simd not only on structs but also enums and unions when we didn't opt in to it)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2025
@rust-timer
Unrolled build for rust-lang#135219
da0a0b5 
Rollup merge of rust-lang#135219 - matthiaskrgr:simd'nt, r=compiler-errors

warn about broken simd not only on structs but also enums and unions when we didn't opt in to it

addresses rust-lang#135208 (comment)

r? ``@Noratrieb``
@bors bors merged commit 485fae5 into rust-lang:master Jan 8, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @compiler-errors @bors @rustbot @Noratrieb