new lint for clone() on an Arc or Rc
#13921
Open
+303
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth rustbot has assigned @Manishearth. Use |
rustbot
added
the
S-waiting-on-review
lapla-cogito
force-pushed
the
arc_rc_unwrap_or_clone
branch
2 times, most recently
from
311d3ee to
1725601
Compare
lapla-cogito
force-pushed
the
arc_rc_unwrap_or_clone
branch
2 times, most recently
from
0986e73 to
d8ded3f
Compare
lukaslueg
reviewed
Jan 1, 2025
lapla-cogito
force-pushed
the
arc_rc_unwrap_or_clone
branch
2 times, most recently
from
b8a5088 to
174e027
Compare
lukaslueg
reviewed
Jan 1, 2025
lapla-cogito
force-pushed
the
arc_rc_unwrap_or_clone
branch
from
174e027 to
fbd4e37
Compare
lapla-cogito
force-pushed
the
arc_rc_unwrap_or_clone
branch
from
fbd4e37 to
8141c38
Compare
lapla-cogito
force-pushed
the
arc_rc_unwrap_or_clone
branch
from
9b80851 to
0aeca65
Compare
|
This lint should only fire if it is okay to move the arc. (In which case it probably could be rolled into the existing unnecessary_clones lint) |
Manishearth
requested changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13917
Starting with Rust 1.76.0,
std::sync::Arcandstd::rc::Rcsupportunwrap_or_clone. This allows for eliminating unnecessary clones more effectively than usingclonedirectly, and linting for this can help improve efficiency.changelog: [
clone_on_arc_or_rc]: new lint