feat: Add ability to ignore path to autodiscover #5254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
changed the title
lukemassa
force-pushed
the
add_ignore_path_to_autodiscover
branch
from
919e412 to
67638cc
Compare
Signed-off-by: Luke Massa <[email protected]>
lukemassa
force-pushed
the
add_ignore_path_to_autodiscover
branch
from
cf296e1 to
e8c7bd1
Compare
Signed-off-by: Luke Massa <[email protected]>
lukemassa
requested review from
GenPage,
nitrocode and
X-Guardian
and removed request for
a team
github-actions
bot
added
docs
Signed-off-by: Luke Massa <[email protected]>
|
@nitrocode I notice in #859 (comment) you mention adding defaults as well, so I'm actually not sure if this PR will fully address #859, but it's a step in that direction, and a feature that would be useful otherwise. For example in my setup, we have a repo that has some specified projects, and another directory that automation adds and removes directories from, so we want to ignore autoplanning in the former but not the latter. |
|
FYI @krrrr38 who had some thoughts about implementation here as well |
nitrocode
approved these changes
Jan 23, 2025
|
Per conversation in slack, I'm going to try to implement this with globs instead of regexes so we can compare the two options |
|
Closing in favor of the (now merged) alternative #5267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add ability to ignore paths in auto-discovery.
I followed the existing convention of surrounding regexes with
/. It's a bit awkward for paths, so I'm open to removing it.why
It's useful to allow certain directories to be auto discovered, but leave other areas of a repo for explicit configuration.
tests
Added some unit tests
references
Partially addresses #859