Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4947: Update default text of distribution email #4974

Merged
merged 4 commits into from
Feb 4, 2025
+2 −2
Merged

Issue #4947: Update default text of distribution email #4974

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa37242
updating default text
jasonwang7517 Feb 1, 2025
5739cf0
Merge branch 'main' into 4947-update-default-email-text
jasonwang7517 Feb 1, 2025
b7394ed
fixing variable call
jasonwang7517 Feb 2, 2025
8e45f27
Merge remote-tracking branch 'upstream/main' into 4947-update-default…
jasonwang7517 Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/distribution_mailer/partner_mailer.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@
<div class="content">

<!-- START CENTERED WHITE CONTAINER -->
<span class="preheader">Your essentials request has been approved.</span>
<span class="preheader">You have a new distribution from <%= @partner.name %>. Please refer to the attachment for details.</span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alas, what we need is the essential bank's name here, and what you have is the partner's name. When you are manually testing, you should see "Pawnee Diaper Bank". Similarly on the text.

The bank's name can be found at @partner.organization.name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good callout!

<table role="presentation" class="main">

<!-- START MAIN CONTENT AREA -->
Expand Down
2 changes: 1 addition & 1 deletion app/views/distribution_mailer/partner_mailer.text.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Your essentials request has been approved.
You have a new distribution from <%= @partner.name %>. Please refer to the attachment for details.
From: <%= @from_email %>

<%= @default_email_text_interpolated %>
Expand Down