Do not ignore 'rosdep install' failures/errors #957
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophebedard
requested review from
emersonknapp and
MichaelOrlov
and removed request for
a team
MichaelOrlov
approved these changes
Feb 12, 2025
Signed-off-by: Christophe Bedard <[email protected]>
christophebedard
force-pushed
the
christophebedard/rosdep-install-remove-or-true
branch
from
7fcf4d2 to
ac2a9a3
Compare
|
I think I'll bump from |
christophebedard
deleted the
christophebedard/rosdep-install-remove-or-true
branch
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #954
This
|| trueafterrosdep installhas been inaction-ros-cisince the very first implementation: https://github.com/ros-tooling/action-ros-ci/blame/b08ee66c5236c0e9df3b57a86f851e9ca66956af/src/action-ros2-ci.ts#L66-L72. The comment specifically says:This might not be a valid reason. After all, if some keys are missing, then some dependencies will be missing. Also, as laid out in #954, this hides actual errors reported by
rosdepabout dependencies declared inpackage.xmlfiles.