Do not run apt update if skipRosdepInstall==true

[roncapat]

Closes #941

[christophebedard]

Wanting to skip apt update is reasonable. However, since it's currently not tied to the skip-rosdep-install option, I wonder if some people might be relying on action-ros-ci running apt update, e.g., to do something after action-ros-ci runs 🤔 just trying to figure out if this might break someone's workflow.

[roncapat]

Wanting to skip apt update is reasonable. However, since it's currently not tied to the skip-rosdep-install option, I wonder if some people might be relying on action-ros-ci running apt update, e.g., to do something after action-ros-ci runs 🤔 just trying to figure out if this might break someone's workflow.

@christophebedard any further thought on this? If you want I can add an additional boolean to make this backward-compatible in behaviour.

[christophebedard]

I looked into it a bit more:

If someone is using setup-ros, that will take care of running apt update before action-ros-ci. They'd have to not use setup-ros (which would be the case when using a base Docker image, e.g., from setup-ros-docker), but use action-ros-ci and then try to use apt install. I think that should still work because the image should have some version of the apt repo package lists. Therefore, the risk of breaking someone's workflow should be pretty low; it's not worth adding a new option.

I would only ask you to mention this in the description for the skip-rosdep-install option:

action-ros-ci/action.yml

Line 84 in 5816ec0

Skip rosdep install.

. Something like:

diff --git a/action.yml b/action.yml
index 9e3631c..7409aab 100644
--- a/action.yml
+++ b/action.yml
@@ -81,7 +81,7 @@ inputs:
   skip-rosdep-install:
     default: ""
     description: |
-      Skip rosdep install.
+      Skip rosdep install. This also skips `apt update`/`dnf check-update`.
       Set to 'true'.
     required: false
   no-symlink-install:

[roncapat]

@christophebedard done! Sorry for the delay, and happy new year 🎆

[christophebedard]

Thanks for the PR!

[christophebedard]

I released this as 0.3.16/v0.3.